Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for SET IFEQ #189

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Documentation for SET IFEQ #189

merged 3 commits into from
Dec 10, 2024

Conversation

sarthakaggarwal97
Copy link
Contributor

This PR adds the documentation to support valkey-io/valkey#1324

@sarthakaggarwal97
Copy link
Contributor Author

sarthakaggarwal97 commented Nov 20, 2024 •
edited
Loading

@hpatro raised the doc PR for IFEQ. Please check if the IFEQ PR is merged!

@sarthakaggarwal97 sarthakaggarwal97 mentioned this pull request Dec 6, 2024
Merged
zuiderkwast
zuiderkwast reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Just a few nits.

commands/set.md Outdated Show resolved Hide resolved
commands/set.md Outdated Show resolved Hide resolved
@sarthakaggarwal97
documentation for ifeq
ef0b756 
Signed-off-by: Sarthak Aggarwal <[email protected]>
@sarthakaggarwal97
addressing comments
9e79f3a 
Signed-off-by: Sarthak Aggarwal <[email protected]>
zuiderkwast
zuiderkwast approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks

commands/set.md Outdated Show resolved Hide resolved
@zuiderkwast
Update commands/set.md
b3ff941 
Signed-off-by: Viktor Söderqvist <[email protected]>
@zuiderkwast zuiderkwast merged commit aa2aeb3 into valkey-io:main Dec 10, 2024
2 checks passed
@sarthakaggarwal97
Copy link
Contributor Author

Thank you @zuiderkwast :D

@hpatro hpatro mentioned this pull request Dec 12, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zuiderkwast zuiderkwast zuiderkwast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarthakaggarwal97 @zuiderkwast